WebUI Services, fix edit, delete button on top of each other, generate more compact table#1
Open
fbourqui wants to merge 7 commits into
Open
WebUI Services, fix edit, delete button on top of each other, generate more compact table#1fbourqui wants to merge 7 commits into
fbourqui wants to merge 7 commits into
Conversation
Allow for longer description
fbourqui
pushed a commit
that referenced
this pull request
May 13, 2023
Yet another of these :) ``` [2023-04-07T19:55:28.777810+02:00] production.ERROR: Error polling ports module for xxxxxxxxxx. TypeError: Unsupported operand types: string - int in /opt/librenms/includes/polling/ports.inc.php:785 Stack trace: #0 /opt/librenms/includes/polling/functions.inc.php(339): include() #1 /opt/librenms/poller.php(126): poll_device(Array, false) #2 {main} [2023-04-07T19:55:28.780705+02:00] production.ERROR: Unsupported operand types: string - int {"exception":"[object] (TypeError(code: 0): Unsupported operand types: string - int at /opt/librenms/includes/polling/ports.inc.php:785)"} ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix edit, delete button on top of each other in Services page, after update to 22.2.0
generate a more compact table removing big empty space after last service of each device.
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.Screenshot
Before:
After:
