fix(tiptap): require explicit image clicks#5381
Merged
Merged
Conversation
Make image node shells transparent to pointer hit testing while keeping images and resize handles interactive.
✅ Deploy Preview for old-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make image node shells transparent to pointer hit testing while keeping images and resize handles interactive.
Note
Low Risk
Editor-only pointer-event and layout tweaks for image nodes; no auth, data, or API impact.
Overview
Tiptap image node views no longer steal clicks on the padded area around an image. The node view shell is now
pointer-events-none, while the image and resize handles staypointer-events-autoso selection and resizing still work when you hit those targets.Layout is adjusted so editor width lives on
NodeViewWrapper(w-fit, inlinewidth) and the inner container is a full-width block, keeping sizing behavior aligned with the new hit-testing model.Reviewed by Cursor Bugbot for commit 4a5e9be. Bugbot is set up for automated code reviews on this repo. Configure here.