fix(desktop): tuck FAB near caret#5380
Merged
Merged
Conversation
Tuck the active session floating button when the editor caret is near the bottom and cover the chat hover reveal behavior.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tuck the active session floating button when the editor caret is near the bottom and cover the chat hover reveal behavior.
Note
Low Risk
Desktop session UI and FAB positioning only; behavior is covered by new and existing unit tests.
Overview
Unifies when the session floating action button tucks so any visible FAB (chat or listen) moves down when the editor caret is near the bottom, not only the listen button in that case or chat when scroll-hidden.
The
tuckActioncondition inFloatingActionButtonnow requires an active action and tucks onisCaretNearBottomor the existing chat-onlyhiddenpeek behavior. A new test covers the chat FAB tucking at the caret with the same hover-zone reveal (group-hover:translate-y-0) as the hidden-chat case.Reviewed by Cursor Bugbot for commit 9999afa. Bugbot is set up for automated code reviews on this repo. Configure here.