fix(desktop): center empty home actions#5374
Merged
Merged
Conversation
Center the empty home actions in the full surface and make the empty background draggable while preserving action clicks.
✅ Deploy Preview for old-char canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Center the empty home actions in the full surface and make the empty background draggable while preserving action clicks.
Note
Low Risk
UI-only empty-tab layout and Tauri drag-region attributes with no auth, data, or backend impact.
Overview
The empty home tab layout is adjusted so quick actions stay vertically centered in the full tab area and the surrounding chrome can move the window.
EmptyViewdrops the bottommb-12offset and marks the outer flex container withdata-tauri-drag-region.ActionItembuttons setdata-tauri-drag-region="false"so New Note, Start Recording, and Settings still receive clicks inside the draggable surface.Tests add
afterEach(cleanup)and assert the drag region on the action wrapper, removal ofmb-12, and non-draggable behavior on each action button.Reviewed by Cursor Bugbot for commit 55a7a16. Bugbot is set up for automated code reviews on this repo. Configure here.