optimize PRINT to eliminate string rewriting and scanning#38
Open
todd-richmond wants to merge 1 commit into
Open
optimize PRINT to eliminate string rewriting and scanning#38todd-richmond wants to merge 1 commit into
todd-richmond wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the PRINT method does in-place front line erasure for every header line and has other inefficient logic. This causes a performance issue on messages with 100s or even 1000s of headers as well as very arge messages. We notice this processing millions of signed messages per day
This PR eliminates all string rewriting and optimizes end-of-header scanning. It also optimizes for the most common case of PRINTing a complete message in 1 call