Add iPhone 16 and iPhone 17 device frames#40
Conversation
Add portrait bezels from Apple Design Resources for: - iPhone 16: Black, Pink, Teal, Ultramarine, White - iPhone 16 Plus: Black, Pink, Teal, Ultramarine, White - iPhone 16 Pro: Black Titanium, Desert Titanium, Natural Titanium, White Titanium - iPhone 16 Pro Max: Black Titanium, Desert Titanium, Natural Titanium, White Titanium - iPhone 17: Black, Lavender, Mist Blue, Sage, White - iPhone 17 Pro: Cosmic Orange, Deep Blue, Silver - iPhone 17 Pro Max: Cosmic Orange, Deep Blue, Silver Screen slot offsets measured via ImageMagick connected-components analysis. Updated files.json, offsets.json, and version.txt.
There was a problem hiding this comment.
Pull request overview
This PR adds device frame assets for iPhone 16 and iPhone 17 series models to support app screenshot framing. The changes include 29 new PNG device bezels across multiple color variants and the corresponding metadata updates.
Changes:
- Added 29 PNG device frame images for iPhone 16 (5 colors), iPhone 16 Plus (5 colors), iPhone 16 Pro (4 colors), iPhone 16 Pro Max (4 colors), iPhone 17 (5 colors), iPhone 17 Pro (3 colors), and iPhone 17 Pro Max (3 colors)
- Updated configuration files with screen slot offset measurements and device frame file references
- Created new timestamped version directory (1772014847) containing all metadata
Reviewed changes
Copilot reviewed 3 out of 315 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| 1772014847/version.txt | Adds version timestamp for the new device frame release |
| 1772014847/offsets.json | Adds screen slot offset and width measurements for 7 new device models |
| 1772014847/files.json | Expands file list from 254 to 280 entries with new iPhone 16 and 17 frame filenames |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Events-Mate-Apps - I added Copilot to check for anything odd in these configs. Some good findings and some have existed for awhile already. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Yeah what a great catches ! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 315 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I don't have any previous knowledge on frames, so my confidence will be Copilot finding typos and then I believe a bunch of new images can't negatively harm anything. The worse case would be breaking changes in the various json files, which I will double check once Copilot is happy. |
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
The spacing on offsets.json and files.json is what is tricking AI and tooling. It changes the spacing on all lines.
If you normalize spaces the only mistake is the Google Pixel 5\u00a0Sorta Sage one. So if you could - lets match spacing in the json files to match the existing latest format to reduce CI changes and fix the Pixel 5.
The rest of mistakes are existing. At that point I think we can merge this and the fastlane/fastlane pr.
Thanks again!
The frameit-frames repo added iPhone 16 and iPhone 17 device bezels in PR fastlane/frameit-frames#40, but the corresponding Device entries were never registered in device_types.rb. This means frameit fails with "Unsupported screen size" on screenshots captured from any 2024-2025 iPhone, even though the frame PNGs are already available in the catalog. Adds Device entries for: - iPhone 16: 1179x2556 - iPhone 16 Plus: 1290x2796 - iPhone 16 Pro: 1206x2622 - iPhone 16 Pro Max: 1320x2868 (new App Store 6.9" slot) - iPhone 17: 1206x2622 - iPhone 17 Pro: 1206x2622 - iPhone 17 Pro Max: 1320x2868 Also adds titanium color constants used as defaults for the iPhone 16 Pro lineup (Black Titanium, Desert Titanium, Natural Titanium, White Titanium). Display type mappings are intentionally omitted for the new devices: the existing DisplayType enum (in spaceship) does not yet expose a 6.9" App Store slot, and priority-based detection via dimensions already works for compositing. Wiring the upload path to App Store Connect's 6.9" slot is a separate follow-up.
|
Nice thanks guys 🤩 |
Summary
Adds portrait device frame bezels from Apple Design Resources for iPhone 16 and iPhone 17 series.
Companion PR: fastlane/fastlane#29921 (adds device definitions, color constants, and tests)
New frames (29 PNGs):
Screen slot offsets (measured via ImageMagick connected-components):
Updated files:
latest/and timestamped1772014847/foldersfiles.json— 254 → 280 entriesoffsets.json— 7 new device entriesversion.txt— new timestampfixes: #37