Skip to content

fix strict aliasing violations#71

Closed
rafaelvanoni wants to merge 4 commits into
masterfrom
aliasing-fixes
Closed

fix strict aliasing violations#71
rafaelvanoni wants to merge 4 commits into
masterfrom
aliasing-fixes

Conversation

@rafaelvanoni

Copy link
Copy Markdown
Contributor

No description provided.

* Replace Python with shell-script for use during configuration.
@rafaelvanoni rafaelvanoni self-assigned this May 14, 2026
@rafaelvanoni rafaelvanoni requested a review from cmikk May 14, 2026 02:12

@cmikk cmikk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the libmy changes, I've been following the convention:

  1. Check if the changed function / file is actually used in the local project. If not, trim all unused files from the local project's libmy/ subdirectory.
  2. Check if the change has been made at the main libmy repo. If not, and the fix is generally applicable to all users of libmy, make the fix there.
  3. Update the fixed file(s) in applicable project libmy/ subdirectories in a separate commit.

The first is useful cleanup in general, as unused files in libmy/ add noise to code analysis like this.

@rafaelvanoni

Copy link
Copy Markdown
Contributor Author

For the libmy changes, I've been following the convention:

  1. Check if the changed function / file is actually used in the local project. If not, trim all unused files from the local project's libmy/ subdirectory.
  2. Check if the change has been made at the main libmy repo. If not, and the fix is generally applicable to all users of libmy, make the fix there.
  3. Update the fixed file(s) in applicable project libmy/ subdirectories in a separate commit.

The first is useful cleanup in general, as unused files in libmy/ add noise to code analysis like this.

Here's the libmy PR -> farsightsec/libmy#6, will follow up with the other fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants