chore: update typing of Event.signatures to work with recent synapse changes#134
Merged
Conversation
5b7985d to
092e120
Compare
Signature to work with recent synapse changesEvent.signatures to work with recent synapse changes
092e120 to
6dfc230
Compare
163d1c7 to
3eab011
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 7 7
Lines 798 798
Branches 118 118
=======================================
Hits 763 763
Misses 22 22
Partials 13 13 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
Included a temporary commit that had the Synapse dependency point at the appropriate, pending, release branch to handle the new rust class for Signatures on Events. This is removed prior to merging. Tests passing with the temporary commit: https://github.com/famedly/synapse-invite-checker/actions/runs/26519953413 |
3eab011 to
7c4d6dd
Compare
jason-famedly
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit in question:
element-hq/synapse@3e6bf10