Skip to content

chore: update typing of Event.signatures to work with recent synapse changes#134

Merged
FrenchGithubUser merged 1 commit into
mainfrom
tt/fix-signature-type
May 28, 2026
Merged

chore: update typing of Event.signatures to work with recent synapse changes#134
FrenchGithubUser merged 1 commit into
mainfrom
tt/fix-signature-type

Conversation

@FrenchGithubUser

Copy link
Copy Markdown
Member

commit in question:
element-hq/synapse@3e6bf10

@FrenchGithubUser FrenchGithubUser requested a review from a team as a code owner May 26, 2026 16:31
@FrenchGithubUser FrenchGithubUser force-pushed the tt/fix-signature-type branch from 5b7985d to 092e120 Compare May 26, 2026 16:34
@FrenchGithubUser FrenchGithubUser changed the title chore: update typing of Signature to work with recent synapse changes chore: update typing of Event.signatures to work with recent synapse changes May 26, 2026
@FrenchGithubUser FrenchGithubUser force-pushed the tt/fix-signature-type branch from 092e120 to 6dfc230 Compare May 26, 2026 16:41
@FrenchGithubUser FrenchGithubUser force-pushed the tt/fix-signature-type branch 2 times, most recently from 163d1c7 to 3eab011 Compare May 27, 2026 15:09
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.61%. Comparing base (4da25e5) to head (3eab011).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files           7        7           
  Lines         798      798           
  Branches      118      118           
=======================================
  Hits          763      763           
  Misses         22       22           
  Partials       13       13           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da25e5...3eab011. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jason-famedly

Copy link
Copy Markdown
Member

Included a temporary commit that had the Synapse dependency point at the appropriate, pending, release branch to handle the new rust class for Signatures on Events. This is removed prior to merging.

Tests passing with the temporary commit: https://github.com/famedly/synapse-invite-checker/actions/runs/26519953413

@FrenchGithubUser FrenchGithubUser merged commit 2ae5054 into main May 28, 2026
10 of 18 checks passed
@FrenchGithubUser FrenchGithubUser deleted the tt/fix-signature-type branch May 28, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants