experiment to see what heavily parameterized tests look like with #131 speedups#130
Closed
jason-famedly wants to merge 12 commits into
Closed
experiment to see what heavily parameterized tests look like with #131 speedups#130jason-famedly wants to merge 12 commits into
jason-famedly wants to merge 12 commits into
Conversation
…or parameterizing TestCases
…some wiggle room to the room creation timestamp This is important in the case of room version "12", as identical timestamps when rapid-fire creating rooms will often generate the same "room ID" twice in a row. Otherwise harmless for earlier room versions
… there were no invites Been wanting that for a long time
… the TestCase helper can fill this role
…re more room versions
ea7db53 to
5ef481a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 97.24% 95.61% -1.63%
==========================================
Files 7 7
Lines 798 798
Branches 118 118
==========================================
- Hits 776 763 -13
Misses 22 22
- Partials 0 13 +13 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment to see what happens if we combine #129 with #131