fix: clear LiveKit key debounce timestamp on dispose#2400
fix: clear LiveKit key debounce timestamp on dispose#2400marco-a-affinidi wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview
Adds Reviewed by Cursor Bugbot for commit f7c27eb. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2400 +/- ##
==========================================
+ Coverage 59.29% 59.60% +0.31%
==========================================
Files 161 161
Lines 20300 20305 +5
==========================================
+ Hits 12037 12103 +66
+ Misses 8263 8202 -61
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Thanks @td-famedly, looks like auto-merge did not work, do I need to do anything on my side? |
|
@marco-a-affinidi looks like it needs a rebase so you are not outdated with main |
If a LiveKit backend is reused within `makeKeyOnJoinDelay` after dispose, `preShareKey()` may try to resend a recent key even though local key storage was already cleared. That null-key reuse path recurses through key generation and sending until it overflows the stack. Reset `_lastNewKeyTime` on dispose so rejoining generates a fresh key.
Head branch was pushed to by a user without write access
79c0abe to
f7c27eb
Compare
|
Thanks @td-famedly, it's now rebased |
If a LiveKit backend is reused within
makeKeyOnJoinDelayafter dispose,preShareKey()may try to resend a recent key even though local key storage was already cleared. That null-key reuse path recurses through key generation and sending until it overflows the stack.Reset
_lastNewKeyTimeon dispose so rejoining generates a fresh key.