build: (deps): bump sqlite3 from 2.9.4 to 3.3.3#2367
Conversation
AssigneesThe following users could not be added as assignees: Please fix the above issues or remove invalid values from |
edb12a1 to
a489b5f
Compare
a489b5f to
0d31221
Compare
There was a problem hiding this comment.
Automated critical-bug review
I reviewed this PR and the recent commits on main for high-severity correctness regressions (data loss, crashes, security holes, user-facing breakage). I did not find a critical bug in the recently merged feature/fix commits (content scanner, skipScanner, SSSS key centralisation, TOFU cross-signing, isValidMatrixIdStrict, thumbnail/sendAgain, ownPowerLevel, VOIP delayed-event canceller) — they are consistent and well covered by tests.
However, this dependency bump itself is not compatible with the SDK as-is and should not be merged without a coordinated migration. sqlite3 3.x is a major release with breaking changes that this repo directly depends on:
- Won't resolve on the declared SDK floor.
sqlite33.x requires Dart>=3.10(pub reports>=3.9.999), butpubspec.yamldeclaressdk: ">=3.3.0 <4.0.0".dart pub gettherefore fails on the repo's CI toolchain (Dart 3.9.2) and for any downstream consumer on Dart 3.3–3.9:Because matrix depends on sqlite3 >=3.0.0-beta.0 which requires SDK version >=3.9.999 <4.0.0, version solving failed. - Won't compile even on Dart ≥3.10.
sqlite33.0 removedpackage:sqlite3/open.dartandopen.overrideForAll(...), whichlib/src/database/sqflite_encryption_helper/io.dartimports and calls inSQfLiteEncryptionHelper.ffiInit(). Library loading is now done exclusively via build hooks. - Breaks at-rest database encryption.
sqlite33.0 drops the bundled SQLCipher support thatSQfLiteEncryptionHelperrelies on (it loadslibsqlcipherand applies aPRAGMA key). Migrating requires switching to the v3 hooks API plus an alternative such as SQLite3MultipleCiphers.
Recommendation: hold/close this automated bump, or land it as part of a deliberate migration that (a) rewrites SQfLiteEncryptionHelper against the v3 hooks + a supported cipher, and (b) raises the environment: sdk lower bound to >=3.10 — a breaking change that warrants a major version bump. Pinning sqlite3: ^2.x keeps the SDK building across the supported Dart range.
Verified locally: dart pub get --no-example fails with the bumped constraint on Dart 3.9.2 and resolves cleanly when pinned to ^2.x.
Sent by Cursor Automation: Find critical bugs
| slugify: ^2.0.0 | ||
| sqflite_common: ^2.4.5 | ||
| sqlite3: ^2.1.0 | ||
| sqlite3: ^3.3.3 |
There was a problem hiding this comment.
sqlite3 3.x is a breaking major bump that this SDK can't take as-is:
- It requires Dart
>=3.10(pub reports>=3.9.999), but this package declaressdk: ">=3.3.0 <4.0.0"(line 13), sodart pub getfails on CI's Dart 3.9.2 and for consumers on Dart 3.3–3.9. - It removes
package:sqlite3/open.dart/open.overrideForAll, used bylib/src/database/sqflite_encryption_helper/io.dart(SQfLiteEncryptionHelper.ffiInit), so it won't compile. - It drops bundled SQLCipher, which
SQfLiteEncryptionHelperrelies on for at-rest DB encryption.
Recommend keeping sqlite3: ^2.x unless this lands with a full v3-hooks migration + an SDK-floor bump.
Bumps [sqlite3](https://github.com/simolus3/sqlite3.dart) from 2.9.4 to 3.3.3. - [Release notes](https://github.com/simolus3/sqlite3.dart/releases) - [Commits](simolus3/sqlite3.dart@sqlite3-2.9.4...sqlite3-3.3.3) --- updated-dependencies: - dependency-name: sqlite3 dependency-version: 3.3.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
0d31221 to
7788ae7
Compare
|
Superseded by #2393. |


Bumps sqlite3 from 2.9.4 to 3.3.3.
Release notes
Sourced from sqlite3's releases.
... (truncated)
Commits
aa46413Prepare 3.3.3 release97268a5Don't remove hooks if not installed4d492e0Ignore IndexedDB blocks past the file length891f51cAcquire navigator lock before feature detection4e224c2Update to SQLite 3.53.2b01302eMention SQLCipher in upgrade notes4ab8f21Build SQLCipher libraries225d45bPrepare sqlite3_web release 0.9.0243a23fAllow closing WebSqlite instances496ac57Support package_config versions 3.x