chore: Remove hatch scripts and replace with built-in hatch utilities#38
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 94.41% 90.74% -3.68%
==========================================
Files 9 9
Lines 681 681
Branches 96 96
==========================================
- Hits 643 618 -25
Misses 38 38
- Partials 0 25 +25 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s developer/CI commands to use Hatch’s built-in hatch test and hatch fmt flows instead of custom Hatch scripts, and refreshes documentation accordingly.
Changes:
- Update README testing instructions to use
hatch test(with-p/-cflags). - Update CI workflow to run
hatch test -p -cfor tests + coverage. - Extend/adjust
pyproject.tomlHatch environment configuration, including customization of thehatch-testenv scripts for coverage output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| README.md | Updates testing documentation to reflect hatch test usage and flags. |
| pyproject.toml | Adds/adjusts Hatch env dependencies and introduces hatch-test customization for coverage behavior. |
| .github/workflows/tests.yml | Switches CI test execution from hatch run cov to hatch test -p -c. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8c8d468 to
1faf9d4
Compare
1faf9d4 to
0f145d1
Compare
0f145d1 to
a69a7c1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
pyproject.toml:25
requires-pythonwas lowered to >=3.10, but the trove classifiers still only declare 3.11 and 3.12 support. Update theclassifierslist to include Python 3.10 (and any other versions you intend to support, e.g. 3.13 as used in CI) so PyPI metadata matches the actual supported range.
name = "famedly-control-synapse"
description = ''
readme = "README.md"
requires-python = ">=3.10"
license = "AGPL-3.0-only"
keywords = []
authors = [
{ name = "Nicolas Werner", email = "n.werner@famedly.com" },
{ name = "Jason Little", email = "j.little@famedly.com" },
{ name = "Soyoung Kim", email = "s.kim@famedly.com" },
{ name = "Thomast Traineau", email = "t.traineau@famedly.com" },
]
classifiers = [
"Development Status :: 4 - Beta",
"Programming Language :: Python",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a69a7c1 to
daac80a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
daac80a to
56912aa
Compare
Replace
hatch run cov,hatch formatandhatch lintwith properhatch fmtandhatch test ...options. Based on work done for the synapse-invite-checkerFor the moment, using
hatch fmtto run static analysis will run head first into a wall of issues. To run the formatting only, just runhatch fmt -f