Skip to content

chore: Remove hatch scripts and replace with built-in hatch utilities#38

Merged
jason-famedly merged 2 commits into
mainfrom
jason/add-tooling
Apr 15, 2026
Merged

chore: Remove hatch scripts and replace with built-in hatch utilities#38
jason-famedly merged 2 commits into
mainfrom
jason/add-tooling

Conversation

@jason-famedly

Copy link
Copy Markdown
Member

Replace hatch run cov, hatch format and hatch lint with proper hatch fmt and hatch test ... options. Based on work done for the synapse-invite-checker

For the moment, using hatch fmt to run static analysis will run head first into a wall of issues. To run the formatting only, just run hatch fmt -f

Copilot AI review requested due to automatic review settings April 8, 2026 11:34
@jason-famedly jason-famedly requested a review from a team as a code owner April 8, 2026 11:34
@codecov

codecov Bot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (93e9a0f) to head (56912aa).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   94.41%   90.74%   -3.68%     
==========================================
  Files           9        9              
  Lines         681      681              
  Branches       96       96              
==========================================
- Hits          643      618      -25     
  Misses         38       38              
- Partials        0       25      +25     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e9a0f...56912aa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s developer/CI commands to use Hatch’s built-in hatch test and hatch fmt flows instead of custom Hatch scripts, and refreshes documentation accordingly.

Changes:

  • Update README testing instructions to use hatch test (with -p/-c flags).
  • Update CI workflow to run hatch test -p -c for tests + coverage.
  • Extend/adjust pyproject.toml Hatch environment configuration, including customization of the hatch-test env scripts for coverage output.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
README.md Updates testing documentation to reflect hatch test usage and flags.
pyproject.toml Adds/adjusts Hatch env dependencies and introduces hatch-test customization for coverage behavior.
.github/workflows/tests.yml Switches CI test execution from hatch run cov to hatch test -p -c.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread .github/workflows/tests.yml
Comment thread README.md Outdated
Copilot AI review requested due to automatic review settings April 8, 2026 11:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

pyproject.toml:25

  • requires-python was lowered to >=3.10, but the trove classifiers still only declare 3.11 and 3.12 support. Update the classifiers list to include Python 3.10 (and any other versions you intend to support, e.g. 3.13 as used in CI) so PyPI metadata matches the actual supported range.
name = "famedly-control-synapse"
description = ''
readme = "README.md"
requires-python = ">=3.10"
license = "AGPL-3.0-only"
keywords = []
authors = [
  { name = "Nicolas Werner", email = "n.werner@famedly.com" },
  { name = "Jason Little", email = "j.little@famedly.com" },
  { name = "Soyoung Kim", email = "s.kim@famedly.com" },
  { name = "Thomast Traineau", email = "t.traineau@famedly.com" },
]
classifiers = [
  "Development Status :: 4 - Beta",
  "Programming Language :: Python",
  "Programming Language :: Python :: 3.12",
  "Programming Language :: Python :: 3.11",
  "Programming Language :: Python :: Implementation :: CPython",
  "Programming Language :: Python :: Implementation :: PyPy",
]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread pyproject.toml Outdated
Comment thread .github/workflows/tests.yml
Comment thread pyproject.toml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/tests.yml
Comment thread pyproject.toml
Comment thread pyproject.toml

@FrenchGithubUser FrenchGithubUser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me!

@jason-famedly jason-famedly added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 0619853 Apr 15, 2026
10 checks passed
@jason-famedly jason-famedly deleted the jason/add-tooling branch April 15, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants