Merge#4
Merged
Merged
Conversation
Bumps [errata-ai/vale-action](https://github.com/errata-ai/vale-action) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/errata-ai/vale-action/releases) - [Commits](vale-cli/vale-action@v2.1.1...2.1.2) --- updated-dependencies: - dependency-name: errata-ai/vale-action dependency-version: 2.1.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixes #3454 SolaraViz now validates upfront that model is an initialized instance, not a class. The check fires before Solara's reactive system can swallow the bad input, producing a clear, actionable error message. Two cases are handled: - SolaraViz(MyModel, ...) — bare class passed directly - SolaraViz(solara.reactive(MyModel), ...) — class wrapped in reactive Error message includes the concrete fix: 'Did you mean SolaraViz(MyModel(), ...)?' This is a common migration mistake from ModularServer, which took a class. Added tests in tests/visualization/test_solara_viz_class_validation.py.
) * Fix run_model_test capturing initial image instead of updated visualization * Fix ValueError in get_k_nearest_agents when k >= number of agents * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix k>=n and empty space handling in ContinuousSpace * Address review feedback: add warning for k>n, fix test setup, remove unrelated viz change --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jan Kwakkel <j.h.kwakkel@tudelft.nl>
….py` (#3482) * Add diffing engine to core.py * Remove observe usage from ComputedState * Rename _add_parent * fix indentation --------- Co-authored-by: Jan Kwakkel <j.h.kwakkel@tudelft.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR! Please click the
Previewtab and select a PR template:Feature/enhancement PRs require prior maintainer approval in an issue or discussion before they are accepted.