add typed membership backend foundation with invariant tests.#1
Open
falloficaruss wants to merge 8 commits into
Open
add typed membership backend foundation with invariant tests.#1falloficaruss wants to merge 8 commits into
falloficaruss wants to merge 8 commits into
Conversation
|
Performance benchmarks:
|
Add get_group to GroupBy (mesa#3713)
tpike3
reviewed
May 17, 2026
| """Add one typed membership edge if it does not already exist.""" | ||
| if not isinstance(relation, str): | ||
| raise TypeError("relation must be a string") | ||
| triplet = (agent, group, relation) |
There was a problem hiding this comment.
Would it be better to use agent id here which has to be unique?
tpike3
reviewed
May 17, 2026
| def add_membership(self, agent: Hashable, group: Hashable, relation: str) -> None: | ||
| """Add one typed membership edge if it does not already exist.""" | ||
| if not isinstance(relation, str): | ||
| raise TypeError("relation must be a string") |
Owner
Author
There was a problem hiding this comment.
I wanted to keep this first implementation simple. I guess I will change it be Hashable as well.
Owner
Author
There was a problem hiding this comment.
RelationKey = Hashable might be better approach.
| """Initialize empty triplet storage and bidirectional indexes.""" | ||
| self._triplets: set[Triplet] = set() | ||
| self._by_agent: dict[Hashable, set[tuple[Hashable, str]]] = defaultdict(set) | ||
| self._by_group: dict[Hashable, set[tuple[Hashable, str]]] = defaultdict(set) |
There was a problem hiding this comment.
This is a very solid approach. Effectively just capturing the relations in a sparce matrix; nicely done. This gives a really strong base. Nice done!
tpike3
reviewed
May 20, 2026
| ) | ||
|
|
||
| def _to_id(self, entity: Hashable) -> Hashable: | ||
| """Normalize entities to canonical IDs when available.""" |
There was a problem hiding this comment.
This is a nitpick, but want to clearly articulate when somethings ties into the code mesa attributes or functions. In this case the docstring should read something like..
Use mesa.agent "unique_id" as triplet reference
| """Return all memberships as canonical triplets.""" | ||
| return set(self._triplets) | ||
|
|
||
| def assert_invariants(self) -> None: |
There was a problem hiding this comment.
Forgot to mention this is a very nice add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR! Please click the
Previewtab and select a PR template:Feature/enhancement PRs require prior maintainer approval in an issue or discussion before they are accepted.