Fix misleading comments in commsOverlapBench overlap-pair-pgs (#222)#222
Open
MogicianWu wants to merge 1 commit into
Open
Fix misleading comments in commsOverlapBench overlap-pair-pgs (#222)#222MogicianWu wants to merge 1 commit into
MogicianWu wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@MogicianWu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103730559. |
meta-codesync
Bot
changed the title
MogicianWu
added a commit
to MogicianWu/param
that referenced
this pull request
May 4, 2026
…okresearch#222) Summary: Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior. Reviewed By: dsjohns2 Differential Revision: D103730559
MogicianWu
force-pushed
the
export-D103730559
branch
from
8083bcd to
e12ace0
Compare
meta-codesync
Bot
changed the title
MogicianWu
force-pushed
the
export-D103730559
branch
from
e12ace0 to
a80461d
Compare
meta-codesync
Bot
changed the title
MogicianWu
added a commit
to MogicianWu/param
that referenced
this pull request
May 5, 2026
…okresearch#222) Summary: Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior. Reviewed By: dsjohns2 Differential Revision: D103730559
MogicianWu
force-pushed
the
export-D103730559
branch
from
a80461d to
a6b6e50
Compare
…okresearch#222) Summary: Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior. Reviewed By: dsjohns2 Differential Revision: D103730559
MogicianWu
force-pushed
the
export-D103730559
branch
from
a6b6e50 to
1f9514e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior.
Reviewed By: dsjohns2
Differential Revision: D103730559