Skip to content

Use eigenvalue EMA over per-step outer products for per-factor correction #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runame wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use eigenvalue EMA over per-step outer products for per-factor correction #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c61efe
Refactor: extract shared EigendecompositionBasedShampooKroneckerFacto…
runame Feb 8, 2026
6cae824
Refactor: eliminate _compute_outer_product_list via _transform_grad_f…
runame Feb 8, 2026
f9ad19f
Add per-factor eigenvalue correction for Distributed Shampoo
runame Feb 8, 2026
4f8bb06
Add tests for PerFactorEigenvalueCorrectedKLShampooPreconditionerList
runame Feb 9, 2026
84e7807
Add full inverse_exponent_override docstrings to PerFactor config cla…
runame Feb 9, 2026
e1bdea8
Export PerFactor config classes from distributed_shampoo __init__.py
runame Feb 22, 2026
89715c9
Use eigenvalue EMA over per-step outer products for per-factor correc…
runame Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions distributed_shampoo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
EigendecomposedKLShampooPreconditionerConfig,
EigendecomposedShampooPreconditionerConfig,
EigenvalueCorrectedShampooPreconditionerConfig,
PerFactorEigenvalueCorrectedKLShampooPreconditionerConfig,
PerFactorEigenvalueCorrectedShampooPreconditionerConfig,
FSDPDistributedConfig,
FSDPParamAssignmentStrategy,
FullyShardDistributedConfig,
Expand Down Expand Up @@ -92,6 +94,8 @@
"RootInvKLShampooPreconditionerConfig", # Based on `RootInvShampooPreconditionerConfig`.
"EigendecomposedShampooPreconditionerConfig", # Based on `ClassicShampooPreconditionerConfig`.
"EigendecomposedKLShampooPreconditionerConfig", # Based on `EigendecomposedShampooPreconditionerConfig`.
"PerFactorEigenvalueCorrectedShampooPreconditionerConfig", # Based on `EigendecomposedShampooPreconditionerConfig`.
"PerFactorEigenvalueCorrectedKLShampooPreconditionerConfig", # Based on `PerFactorEigenvalueCorrectedShampooPreconditionerConfig`.
"EigenvalueCorrectedShampooPreconditionerConfig", # Based on `BaseShampooPreconditionerConfig`.
"DefaultEigenvalueCorrectedShampooConfig", # Default `EigenvalueCorrectedShampooPreconditionerConfig` using `EighEigendecompositionConfig`.
"DefaultSOAPConfig", # Default `EigenvalueCorrectedShampooPreconditionerConfig` using `QREigendecompositionConfig`.
Expand Down
8 changes: 8 additions & 0 deletions distributed_shampoo/distributed_shampoo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
EigendecomposedKLShampooPreconditionerList,
EigendecomposedShampooPreconditionerList,
EigenvalueCorrectedShampooPreconditionerList,
PerFactorEigenvalueCorrectedKLShampooPreconditionerList,
PerFactorEigenvalueCorrectedShampooPreconditionerList,
RootInvKLShampooPreconditionerList,
RootInvShampooPreconditionerList,
)
Expand All @@ -76,6 +78,8 @@
EigendecomposedShampooPreconditionerConfig,
EigenvalueCorrectedShampooPreconditionerConfig,
EPSILON,
PerFactorEigenvalueCorrectedKLShampooPreconditionerConfig,
PerFactorEigenvalueCorrectedShampooPreconditionerConfig,
FILTERED_GRAD,
FILTERED_GRAD_LIST,
FSDPDistributedConfig,
Expand Down Expand Up @@ -687,17 +691,21 @@ def _preconditioner_config_to_list_cls(
RootInvShampooPreconditionerConfig()
| EigendecomposedShampooPreconditionerConfig()
| EigenvalueCorrectedShampooPreconditionerConfig()
| PerFactorEigenvalueCorrectedShampooPreconditionerConfig()
| RootInvKLShampooPreconditionerConfig()
| EigendecomposedKLShampooPreconditionerConfig()
| PerFactorEigenvalueCorrectedKLShampooPreconditionerConfig()
):
preconditioner_config_to_list_cls: dict[
type[PreconditionerConfig], Callable[..., PreconditionerList]
] = {
RootInvShampooPreconditionerConfig: RootInvShampooPreconditionerList,
EigendecomposedShampooPreconditionerConfig: EigendecomposedShampooPreconditionerList,
EigenvalueCorrectedShampooPreconditionerConfig: EigenvalueCorrectedShampooPreconditionerList,
PerFactorEigenvalueCorrectedShampooPreconditionerConfig: PerFactorEigenvalueCorrectedShampooPreconditionerList,
RootInvKLShampooPreconditionerConfig: RootInvKLShampooPreconditionerList,
EigendecomposedKLShampooPreconditionerConfig: EigendecomposedKLShampooPreconditionerList,
PerFactorEigenvalueCorrectedKLShampooPreconditionerConfig: PerFactorEigenvalueCorrectedKLShampooPreconditionerList,
}
beta2 = group[BETAS][1]
return preconditioner_config_to_list_cls[type(preconditioner_config)](
Expand Down
Loading
Loading