Fix order of bos_idx and eos_idx assignment#65
Conversation
in create_zero_shot_syntax
|
Hi @lsrami! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Why?
Fixed incorrect variable assignment order for BOS/EOS token indices in the create_zero_shot_syntax method. The original code assigned eos_idx to the BOS token and bos_idx to the EOS token, causing the model to use incorrect special tokens during sequence construction. This bug would lead to malformed input sequences and potentially incorrect model predictions in zero-shot learning scenarios.
How?
Technical Decision:
Location:
Test Plan
Testing Approach:
Reproduction: