Skip to content

adding account, qos, time as optional args [2/n]#99

Draft
luccabb wants to merge 4 commits into
mainfrom
add_opt_args
Draft

adding account, qos, time as optional args [2/n]#99
luccabb wants to merge 4 commits into
mainfrom
add_opt_args

Conversation

@luccabb
Copy link
Copy Markdown
Contributor

@luccabb luccabb commented Oct 2, 2025

Summary

adding account, qos, time as optional args that gets passed down to the CLI

Test Plan

$ cscope job-gen task slurm --num-gpus=4 --partition=h100 --format=sbatch --time="1234234" --qos='learn'
#!/bin/bash
#SBATCH --cpus-per-task=96
#SBATCH --mem=999G
#SBATCH --ntasks-per-node=1
#SBATCH --gres=gpu:4
#SBATCH --partition=h100
#SBATCH --qos=learn
#SBATCH --time=1234234

@luccabb luccabb requested review from gunchu and skalyan as code owners October 2, 2025 21:31
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 2, 2025
@luccabb luccabb requested a review from uralik October 2, 2025 21:46
Base automatically changed from add_num_gpus to main October 2, 2025 22:27
Copy link
Copy Markdown
Contributor

@gunchu gunchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sit on this one for a while

@luccabb luccabb marked this pull request as draft October 6, 2025 17:40
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 27, 2026

Hi @luccabb!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants