adding slurm cmd option to CLI [3/n]#100
Conversation
|
How do we expect |
|
@gunchu yeah that's correct, this optional arg is just in case you want custom cmds to be appended to |
gunchu
left a comment
There was a problem hiding this comment.
Let's sit on this one for a while
|
Can we convert this and PR99 to Draft state, given @gunchu guidance. |
|
Hi @luccabb! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
allowing users to pass slurm cmd via the CLI and auto-ingest this in sbatch/srun output
Test Plan
observe how sbatch and srun now has the slurm cmd: