Clarify tailing iterator late insert behavior#14794
Open
richinmrudul wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Clarifies tailing iterator documentation around the view refreshed by Seek()/SeekToFirst() and the fact that Next() is not guaranteed to observe keys inserted after the most recent seek, even when those keys sort after the last key returned.
Adds a focused test covering the case where a key is inserted into the mutable memtable after the iterator has already sought, but is skipped by Next() because the mutable memtable iterator is not refreshed until a later seek/renewal.
Refs #14677
Test Plan:
make db_tailing_iter_test -j8
./db_tailing_iter_test --gtest_filter='Tailing'
git diff --check
make check-sources