Add pkgconfig generation to cmake#883
Conversation
|
Hi @wreedb! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
This PR provides two pkg-config file templates, for
openzlandopenzl_cpp,along with
configure_filecalls for them in the corresponding section of the cmake build.Type of Change
Build/CI changes
Test Plan
I built the project using a few different
CMAKE_INSTALL_PREFIX's to ensure the installation path was being handled correctly, as well as usingpccriticfrompkgconfto validate the installed.pcfiles, and ensure they weren't missing any major fields.Test Configuration
I noticed there was a comment in the
CMakeLists.txtnoting intent to add support for pkgconfig files in the installation, and I happen to be very familiar with the format, so I decided I'd lend a hand.The
.pc.infiles in the commit reside inscripts/, though this may not be the correct place for them. I initially tried to put them inbuild-scripts/cmake/which felt like a much more sensible location, however that led me to notice this line in the.gitignore:Which... I imagine must be a mistake, as this matches the
build-scripts/directory, which prevented me from adding them to that location.