Skip to content

Add pkgconfig generation to cmake#883

Open
wreedb wants to merge 2 commits into
facebook:devfrom
wreedb:add-pkgconfig-to-cmake
Open

Add pkgconfig generation to cmake#883
wreedb wants to merge 2 commits into
facebook:devfrom
wreedb:add-pkgconfig-to-cmake

Conversation

@wreedb

@wreedb wreedb commented Jul 19, 2026

Copy link
Copy Markdown

Summary

This PR provides two pkg-config file templates, for openzl and openzl_cpp,
along with configure_file calls for them in the corresponding section of the cmake build.

Type of Change

Build/CI changes

Test Plan

I built the project using a few different CMAKE_INSTALL_PREFIX's to ensure the installation path was being handled correctly, as well as using pccritic from pkgconf to validate the installed .pc files, and ensure they weren't missing any major fields.

Test Configuration

  • Compiler: GCC 16.1.0
  • Build type: CMake v4.2.1
  • Platform(s): amd64 Linux

I noticed there was a comment in the CMakeLists.txt noting intent to add support for pkgconfig files in the installation, and I happen to be very familiar with the format, so I decided I'd lend a hand.

The .pc.in files in the commit reside in scripts/, though this may not be the correct place for them. I initially tried to put them in build-scripts/cmake/ which felt like a much more sensible location, however that led me to notice this line in the .gitignore:

build-*/

Which... I imagine must be a mistake, as this matches the build-scripts/ directory, which prevented me from adding them to that location.

@meta-cla

meta-cla Bot commented Jul 19, 2026

Copy link
Copy Markdown

Hi @wreedb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the cla signed label Jul 19, 2026
@meta-cla

meta-cla Bot commented Jul 19, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant