[Accton][minipack3bam] Restore SCM_CPLD default write protect and OOB control#1194
Open
brandonchuang wants to merge 1 commit into
Open
[Accton][minipack3bam] Restore SCM_CPLD default write protect and OOB control#1194brandonchuang wants to merge 1 commit into
brandonchuang wants to merge 1 commit into
Conversation
… control Summary: Remove the initRegSettings configuration for SCM_CPLD (register 0xB1) and rely on hardware default values instead. Previously, we explicitly set register 0xB1 to 0x2 during CPLD initialization: - Bit[0] = 0: Disable SCM EEPROM write protect (writable) - Bit[1] = 1: Transfer OOB switch EEPROM control from 88E6321 to SCM Using hardware default values provides better consistency and reduces the risk of misconfiguration during initialization. Write protection can be managed explicitly when needed rather than being disabled by default. Changes: - Removed initRegSettings block from SCM_CPLD configuration - Register 0xB1 will now use hardware default value (0x1): - Bit[0] = 1: Enable SCM EEPROM write protect (default protected) - Bit[1] = 0: OOB switch EEPROM controlled by 88E6321 (default) Test Plan: 1. Build and deploy the updated configuration to the target platform 2. Check platform manager logs for any CPLD-related errors 3. Verify register 0xB1 uses default value (0x1): # Read register 0xB1 (decimal 177) i2cget -f -y 4 0x35 0xB1 # Expected output: 0x01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary:
Remove the initRegSettings configuration for SCM_CPLD (register 0xB1) and rely on hardware default values instead.
Previously, we explicitly set register 0xB1 to 0x2 during CPLD initialization:
Using hardware default values provides better consistency and reduces the risk of misconfiguration during initialization. Write protection can be managed explicitly when needed rather than being disabled by default.
Changes:
Test Plan:
#Read register 0xB1 (decimal 177)
i2cget -f -y 4 0x35 0xB1
#Expected output: 0x01
[mp3bam] platform_manager.txt
[mp3bam] scm_write_protect_test.txt