fix(core): pagination dots WCAG contrast (1.4.11) and use-of-color (1.4.1) - #4703
Open
gonzoblasco wants to merge 1 commit into
Open
fix(core): pagination dots WCAG contrast (1.4.11) and use-of-color (1.4.1)#4703gonzoblasco wants to merge 1 commit into
gonzoblasco wants to merge 1 commit into
Conversation
gonzoblasco
requested review from
cixzhang,
ejhammond and
imdreamrunner
as code owners
August 4, 2026 12:50
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
August 4, 2026 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the pagination dots variant contrast and use-of-color failures reported in #4652 (which reopens #3654).
1. WCAG 1.4.11 - Non-text contrast (inactive dots)
The inactive dots used
--color-neutral(rgba(5, 54, 89, 0.1)light /rgba(223, 226, 229, 0.2)dark) as a translucent background. Because it is 20% alpha, the effective color depends on the surface behind it and fails the 3:1 threshold:#D9E1E7#F1F4F7#3A3B3C#111112Fix: inactive dots now use
--color-text-secondary(#4E606Flight /#AAAFB5dark) - 5.90:1 (light) / 8.55:1 (dark), well above 3:1.2. WCAG 1.4.1 - Use of Color (active dot)
Previously the only visual difference between active and inactive dots was a color change (neutral - accent), with no secondary cue. Users who cannot perceive the color difference had no way to identify the current page.
Fix: the active dot now renders as an outlined ring (inset accent ring with transparent fill) instead of a solid fill. Active vs inactive is now distinguished by shape (ring vs fill), not only by color. The inset ring adds no size, so the dot layout is unchanged.
Changeset
fix-pagination-dots-contrast.md-@astryxdesign/core: patchOut of scope (tracked in the issue thread)
0x33(20%) background designed for white surfaces, which fails on colored cards. Needs a design decision (bump alpha vs. constrain usage vs. force semantic variants) - already flagged as pending in [Bug] Widespread WCAG 2.1 AA colour contrast failures across Design System #4652.theme-neutral, hardcodedlight-dark(...)breaking token override): separate PR by @is0060hf.Verification
check:changesetsRef #4652