fix(cli): remove dead @xds/theme-default collapse from the v0.1.0 upgrade codemods - #4702
Open
ejhammond wants to merge 2 commits into
Open
fix(cli): remove dead @xds/theme-default collapse from the v0.1.0 upgrade codemods#4702ejhammond wants to merge 2 commits into
ejhammond wants to merge 2 commits into
Conversation
…ecifiers codemod theme-default was dropped when the public scope moved from @xds/* to @astryxdesign/* in v0.1.0, so no v0.1.x consumer imported it. The @xds/theme-default -> @astryxdesign/theme-neutral rename in the module-specifiers codemod was therefore dead, and could rewrite unrelated source to a package the app never declared as a dependency. Drop the rename and the theme-default entry in the collapsed-theme export remap. The @xds/theme-daily -> theme-neutral collapse and its defaultTheme -> neutralTheme export remap are unchanged.
ejhammond
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
August 4, 2026 12:04
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
…nd declare-module codemods Extends the module-specifiers fix to the other two v0.1.0 upgrade codemods, which still collapsed @xds/theme-default to @astryxdesign/theme-neutral: - migrate-xds-css-surfaces: dropped the theme-default @import rewrite (the @xds/theme-default/theme.css -> theme-neutral/theme.css rewrite that pointed CSS imports at a package the app never declared). Kept the theme-daily collapse and the core xds.css -> astryx.css file rename. - migrate-xds-declare-module: dropped the theme-default entry from its rename map. Kept theme-daily. theme-default was dropped at the v0.1.0 scope move, so the collapse was dead for every consumer. theme-daily -> theme-neutral is a real migration and is unchanged.
ejhammond
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
@xds/theme-default→@astryxdesign/theme-neutralcollapse from all three v0.1.0 upgrade codemods:migrate-xds-module-specifiers.mjs— dropped the@xds/theme-defaultentry fromPACKAGE_RENAMESand from the collapsed-theme export-remap set.migrate-xds-css-surfaces.mjs— dropped the@xds/theme-default/*→@astryxdesign/theme-neutral/*@importrewrite.migrate-xds-declare-module.mjs— dropped the@xds/theme-defaultentry from itsPACKAGE_RENAMESmap.Why
We have a different migration path for internal vs external "theme-default" usages (internal maps to an internal theme, external maps to the "neutral" theme) and these were fighting one another--the external codemod ran first with default->neutral, then the internal codemod would not find any "default" references to migrate.
Rather than solve the (harder) sequencing issue, we noticed that there are no external consumers using the default theme in the first place. It was never published in OSS. So we can "cheat" here and just remove the external facing codemod leaving "default" references alone for the internal codemod to migrate.
Changes
meta.descriptionupdated to saytheme-daily -> theme-neutralonly.@xds/theme-dailyso the collapse + alias behavior stays covered.declare-modulehad no theme-default-specific test.Testing
vitest runon the v0.1.0 codemod suite — 50 tests pass across all five files. ESLint clean on the changed files.