fix(Table): name the row-status column header - #4693
Open
AKnassa wants to merge 1 commit into
Open
Conversation
axe empty-table-header (minor): the row-status gutter column rendered a blank <th>, so AT users got a nameless column header. The header now carries VisuallyHidden text from a new i18n key (@astryx.table.rowStatus.columnHeader, default 'Row status') — i18n-key-only override like the selection/rowExpansion plugin strings, no new config prop. Tests pin both the accessible name and that it stays visually hidden. Baseline: -2 entries. Verified: 9/9 plugin tests + i18n catalog guard, eslint clean, axe audit 0 issues on both TableRowStatus stories with --fail-on-new. Part of facebook#4681.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
AKnassa
marked this pull request as ready for review
August 4, 2026 01:49
AKnassa
requested review from
cixzhang,
ejhammond,
humbertovirtudes and
imdreamrunner
as code owners
August 4, 2026 01:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4681 (weekly a11y scan). Clears both
TableRowStatus::*::empty-table-headerbaseline entries.What this does
The row-status plugin renders a narrow colored-gutter column whose
<th>was intentionally blank, leaving screen reader users a nameless column header. The header now carries visually hidden text: sighted users still see a blank gutter, assistive technology announces "Row status".What changed
useTableRowStatusrenders<VisuallyHidden>text from a new i18n key (@astryx.table.rowStatus.columnHeader, default "Row status") instead of an empty header, withtadded to the column memo deps (same shape as the rowExpansion plugin's strings).InternationalizationProviderlike every other built-in Table plugin string; deliberately no new config prop.thtext would fail).Known relatives, not in this PR
useTableRowExpansionhas the identical blank-header pattern but zero baseline entries (its stories appear to fall outside the scan), andTable/types.tsdocumentsheader: ''as the example for action columns. Both are follow-up candidates.Verification
9/9 plugin tests plus the i18n catalog guard (29/29 combined), eslint clean, and the repo's axe audit with
--fail-on-new: 0 issues on both TableRowStatus stories.