Skip to content

fix(core): center directional icons inside controls - #4688

Open
zeroryu wants to merge 1 commit into
mainfrom
fix/center-directional-icon-wrappers
Open

fix(core): center directional icons inside controls#4688
zeroryu wants to merge 1 commit into
mainfrom
fix/center-directional-icon-wrappers

Conversation

@zeroryu

@zeroryu zeroryu commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • normalize the shared RTL mirror wrapper to centered inline-flex layout
  • fix the SideNav collapse chevron without changing Button sizing or RTL transforms
  • apply the same baseline fix to gallery, tree, and table directional controls
  • add the core patch changeset and Next-generated docsite agent rules

Verification

  • pnpm exec vitest run packages/core/src/SideNav/SideNav.test.tsx packages/core/src/Calendar/Calendar.test.tsx packages/core/src/Carousel/Carousel.test.tsx packages/core/src/Lightbox/Lightbox.test.tsx packages/core/src/TreeList/TreeList.test.tsx (289 tests)
  • pnpm -F @astryxdesign/core typecheck
  • pnpm -F @astryxdesign/core build
  • pnpm check:sync
  • pre-commit repository checks

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 3, 2026
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 3, 2026 8:09pm

Request Review

@imdreamrunner imdreamrunner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two new Markdown files don’t seem to be related to this PR. Could you either remove them or explain why you think they’re necessary?

Comment thread apps/docsite/AGENTS.md
@@ -0,0 +1,8 @@
<!-- BEGIN:nextjs-agent-rules -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file and apps/docsite/CLAUDE.md intended to be part of this PR>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants