feat(selector): add ghost variant - #4684
Open
cixzhang wants to merge 1 commit into
Open
Conversation
cixzhang
requested review from
ejhammond,
imdreamrunner and
josephfarina
as code owners
August 3, 2026 17:11
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
August 3, 2026 18:04
cixzhang
force-pushed
the
feat/selector-ghost-variant
branch
from
August 3, 2026 20:32
71e7c9d to
a3868d7
Compare
cixzhang
enabled auto-merge (squash)
August 3, 2026 21:01
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsMultiSelector (@astryxdesign/core) · View in Storybook
Selector (@astryxdesign/core) · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
variant="ghost"toSelectorandMultiSelectorso picker-style controls can sit visually alongside ghost buttons in toolbar rows. The existing bordered form-control treatment is now namedvariant="input"and remains the default.What changed
variant="input" | "ghost"on the theme target surface for both selector components.statusVariant="tooltip"when status feedback needs to stay inline.Testing
vitest run packages/core/src/Selector/Selector.test.tsx packages/core/src/MultiSelector/MultiSelector.test.tsxpnpm -F @astryxdesign/core typecheckeslinton changed implementation, test, story, and example filesnode scripts/check-sync.jsnode scripts/check-changesets.mjsgit diff --checknode apps/docsite/scripts/generate-data.mjs(succeeded; fresh-worktree warnings only for unbuilt theme package outputs)