Move inline scripts to the script.js file to comply with strict CSP#104
Open
odinserj wants to merge 1 commit into
Open
Move inline scripts to the script.js file to comply with strict CSP#104odinserj wants to merge 1 commit into
odinserj wants to merge 1 commit into
Conversation
* Rename `btn_go` to `btn_tags_go` to be more specific * Move base URL to `data-base-url` attribute * Add a new callback function in `script.js` * Remove `onclick` handler in favor of the new callback * Remove inline `script` tags * Regenerate dashboard pages with Razor Generator
bhavishyachandra
added a commit
to Hangtools/Hangfire.Tags
that referenced
this pull request
May 19, 2026
bhavishyachandra
added a commit
to Hangtools/Hangfire.Tags
that referenced
this pull request
May 19, 2026
…#2) * Rebrand packages to Hangtools and add NuGet publish workflow * Pull in changes from face-it/Hangfire.Tags#104 * Clean up old AppVeyor/FaceIT URLs and repoint to Hangtools * Make NuGet workflow pack each publishable package explicitly * Avoid Hangfire Pro dependency in public publish workflow * Address Copilot PR comments on tag redirect and icon URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
There are two inline
<script>blocks in TagsJobsPage.cshtml and TagsSearchPage.cshtml pages. They are used to provide callback function for the "Go" button if Dropdown mode is activated. However, this feature does not work in web applications with strict Content Security Policy where inline scripts are prohibited, leading to an error.This PR moves callbacks to the already existing
script.jsfile with a callback specified for the "Go" button and removes inline script tags.btn_gotobtn_tags_goto be more specificdata-base-urlattributescript.jsonclickhandler in favor of the new callbackscripttagsPlease let me know there's anything else that should be considered.