Skip to content

feat: add textfield custom element#96

Merged
digitalsadhu merged 9 commits into
nextfrom
add_textfield_component
Aug 30, 2022
Merged

feat: add textfield custom element#96
digitalsadhu merged 9 commits into
nextfrom
add_textfield_component

Conversation

@digitalsadhu

@digitalsadhu digitalsadhu commented Aug 14, 2022

Copy link
Copy Markdown
Collaborator

Adds a textfield element based on the React version.

TODO

  • prefix/suffix
  • more tests
  • docs

This is ready for feedback now. It's a pretty direct port of the React version.
I haven't attempted to spread out additional attributes onto the input.
Will wait for the result of the RFC discussion here fabric-ds/issues#101 though this component contains a fairly large set of possible attributes already.

@digitalsadhu digitalsadhu requested a review from a team August 17, 2022 02:25
@pearofducks

Copy link
Copy Markdown
Contributor

Might not be relevant to this PR, but there's a missing peer dep - and this will be very cranky on the next version of NPM (or for pnpm users)

 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
└─┬ @babel/eslint-parser 7.18.9
  └── ✕ missing peer @babel/core@>=7.11.0

@pearofducks

pearofducks commented Aug 24, 2022

Copy link
Copy Markdown
Contributor

npm run dev doesn't work because glob isn't in deps - are we using another command to develop/review things?

@digitalsadhu

Copy link
Copy Markdown
Collaborator Author

hmm, no that's the right command. It works fine with npm so hadn't run into that issue.

@pearofducks

Copy link
Copy Markdown
Contributor

Probably being brought in by transitive dep then?

@digitalsadhu

Copy link
Copy Markdown
Collaborator Author

Yea not sure what's up. I can repro your issue with pnpm but it works fine with npm and yarn.

@pearofducks

pearofducks commented Aug 24, 2022

Copy link
Copy Markdown
Contributor
  /@eik/cli/2.0.22:
    resolution: {integrity: sha512-76Xfkd/+anI3C+LdnDeQtnG37YnZrz+zyTFw3t2RnD6PcynAv6+ZeTKgv6GlljCNGOQLb/na0HGuR6mwZmTgzQ==}
    hasBin: true
    dependencies:
      '@eik/common': 3.0.1
      abslog: 2.4.0
      boxen: 5.1.2
      bytes: 3.1.2
      chalk: 4.1.2
      copy: 0.3.2
      date-fns: 2.28.0
      form-data: 4.0.0
      glob: 7.2.0

Transitive dep of @eik/cli (amongst others). That's why it's working on the other package managers. pnpm has more strict hoisting rules.

@digitalsadhu

Copy link
Copy Markdown
Collaborator Author

ah right cool, fixed!

@pearofducks pearofducks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@digitalsadhu digitalsadhu merged commit 9d5e3c0 into next Aug 30, 2022
@digitalsadhu digitalsadhu deleted the add_textfield_component branch August 30, 2022 01:51
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0-next.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants