Skip to content

Remove Function constuctor usage#49

Open
jketcham wants to merge 1 commit into
f:masterfrom
jketcham:master
Open

Remove Function constuctor usage#49
jketcham wants to merge 1 commit into
f:masterfrom
jketcham:master

Conversation

@jketcham

@jketcham jketcham commented Oct 9, 2019

Copy link
Copy Markdown

Addresses #48

@f

f commented Oct 15, 2019

Copy link
Copy Markdown
Owner

This does not actually solve the issue.

new Function("fragments", "return fragments.x.y.z")

is not equal to

fragments['x.y.z']

Thanks!

@f f closed this Oct 15, 2019
@f f reopened this Oct 15, 2019
@f

f commented Oct 15, 2019

Copy link
Copy Markdown
Owner

Oopss sorry. I re-read the code and seems like you're right! 😥 I'll merge it after my tests.

@jketcham

Copy link
Copy Markdown
Author

Awesome, thanks!

@urkle urkle mentioned this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants