Feature/player boost stats#45
Merged
Merged
Conversation
On standard Paper, the JVM resolves the ScheduledTask type when loading AdminGuiChatListener (it appears as a synthetic method parameter from the compiled lambda 't -> processInput(...)'). Since ScheduledTask is Folia-only, Paper could not load the class and Bukkit's event registration failed with: failed to register events for AdminGuiChatListener because io/papermc/paper/threadedregions/scheduler/ScheduledTask does not exist Fix: replace the inline player.getScheduler().run(...) call with FoliaScheduler.runEntityTask(), which already contains the Folia reference in its own class so the JVM only resolves ScheduledTask when that method is actually executed on a Folia server. This also fixes a latent thread-safety issue: processInput() accesses the player's PersistentDataContainer, which must be done on the main thread (Paper) or entity region thread (Folia). The previous Paper branch called processInput directly on the async chat thread.
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.