Batch animation reads and writes to avoid layout thrash#249
Merged
Conversation
Batch animation reads and writes so the browser lays out once instead of once per element (removes layout thrash in the reveal path). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
amjadr360
force-pushed
the
fix-animations-layout-thrash-lcp
branch
from
0a3cd32 to
03bf12b
Compare
Contributor
|
@amjadr360 how should I test test and what should I be looking for to know that this is working as expected? |
Contributor
Author
Since this only refactors the code, no behavior is changed — just checking if the animation is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://extendify.slack.com/archives/C07S030UWSJ/p1780329470747489
Refactors the animation reveal script to batch DOM reads and writes so the browser lays out once instead of once per element. Previously it measured each element's position right after changing its styles, which forces a reflow on every animated element.
Behavior is unchanged — same animations, same reveal timing.