fix: make all tables scrollable - #2485
Open
krzysdz wants to merge 1 commit into
Open
Conversation
Markdown tables are automatically wrapped in .table-scroller div, but raw HTML tables have to be wrapped manually. Tables in migrating-4.mdx were simple an have been rewritten using markdown syntax.
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
One thing that I noticed while making these changes: #2221 removed a table from 5.x writing middleware docs, but left it in 4.x. The table served as an explanation of some things shown on an illustration, but the illustration has been updated to include these descriptions, so 4.x version is labelled twice. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown tables are automatically wrapped in a
<div class="table-scroller">, but raw HTML tables have to be wrapped manually. Tables inmigrating-4.mdxare simple an have been rewritten using markdown syntax.The tables in "Express behind proxies" are quite large and contain a lot embedded markdown (code blocks, lists), which does not play well with the simple regex1 I've been using. These I have wrapped manually like it was previously done in #1968.
Fixes #2484
Footnotes
^\s*<tr>\s*<td.*?>\s*([\w\W]*?)\s*</td>\s*<td.*?>\s*([\w\W]*?)\s*</td>\s*</tr>->| $1 | $2 |. The regex isn't really a problem, but multiline content in tables is. ↩