fix: resolve relative links in get-contributing.sh sync script (#2416) - #2427
Merged
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bjohansebas
force-pushed
the
fix/2416-triager-guide-link
branch
from
July 5, 2026 02:17
6450f04 to
5c965b1
Compare
bjohansebas
approved these changes
Jul 5, 2026
Member
|
thanks @mkco0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2416
On the contributing page, the "triage process document" link returns a 404 on GitHub.
The link text comes from
docs/GOVERNANCE.mdinexpressjs/discussions, where it's written as a relative path:contributing/triager-guide.md. That works on GitHub because the file lives underdocs/, so the real target isdocs/contributing/triager-guide.md.When
.github/scripts/get-contributing.shsyncs that content into the website, it turns relative links into full GitHub URLs. However, it was treating them as if they started from the repo root, dropping thedocs/part of the path.My proposed fix is to resolve relative links from the directory of the source file being fetched, then regenerate
src/content/pages/en/resources/contributing.mdx. Other locale files aren't touched in this PR since they come from Crowdin, notget-contributing.sh.Verification
Ran
get-contributing.shfrom.github/scripts/:Before/after link at
/en/resources/contributing/#becoming-a-triager:Destination on GitHub: