Skip to content

ci: remove base_url from crowdin workflows #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjohansebas merged 3 commits into from
Aug 2, 2025
Merged

ci: remove base_url from crowdin workflows #1979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b350a2
ci: remove base_url from crowdin workflows
bjohansebas Jul 19, 2025
1cab29a
Merge branch 'gh-pages' into crowdin-base-url
bjohansebas Jul 19, 2025
a5af82e
Merge branch 'gh-pages' into crowdin-base-url
ShubhamOulkar Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/crowdin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
upload_sources: true
upload_translations: false
download_translations: false
base_url: 'https://express.api.crowdin.com'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update-external-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ jobs:
pull_request_body: >
New Crowdin translations from the [express.js crowdin project](https://express.crowdin.com/u/projects/1). cc: @expressjs/docs-wg
pull_request_base_branch_name: 'gh-pages'
base_url: 'https://express.api.crowdin.com'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
Expand Down
1 change: 1 addition & 0 deletions crowdin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ files:
translation: /%two_letters_code%/index.md
preserve_hierarchy: true
project_id_env: CROWDIN_PROJECT_ID
base_url: 'https://express.api.crowdin.com'
api_token_env: CROWDIN_PERSONAL_TOKEN