Complete recurrence generation#45
Merged
Merged
Conversation
this enforces uniqueness, and sorts for later ease of use in recurrence calculations some entries, such as the order of the weekday entries (if any), can depend on OTHER entries such as the weekday start entry
this simplifies a number of function heads and allows generate_set/2 to easily be called repeatedly by catching the state for later use
this prevents infinite looping in streams
fixes generation of invalid dates
instead of setting the date components on the original datetime, set the time components on the new (shifted) datetime. this way when the timezone changes (e.g. EDT -> EST) due to shifting the day, that change is retained.
using [new_date | acc] is fine as the list always gets sorted later anyways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the recurrence implementation with a fully implemented RFC5545 RRULE implementation. Accepts both bare
ICal.Recurrencestructs as well as events, todos, and journals.All example RRULES from RFC5545 have been added to the test suite for conformance. Most recurrences take <200 microsends to fill, though a few take a couple milliseconds. Probably room for further optimizations, but this at least works.
This also bumps the version to 2.0.0, improves documentation, and updates the CHANGELOG.md file for release readiness.