Add tests for to_date_in_timezone/2 and to_date/3 when VALUE=DATE#38
Merged
Merged
Conversation
matthewlehner
force-pushed
the
deserialize-date-tests
branch
from
3dd4d2f to
659315b
Compare
Cover the normal case, trailing Z, unparseable input, and both DST edge cases: ambiguous times (fall-back) and gap times (spring-forward).
matthewlehner
force-pushed
the
deserialize-date-tests
branch
from
659315b to
e86d7c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting started on the
Timex.parselogic and… it was a bit more complicated than I thought.I figure adding a bit more test coverage here to show what's weird/broken at the moment.
These edge cases are pretty wild!
Here's a link to the RFC, for reference: https://www.rfc-editor.org/rfc/rfc5545#section-3.3.5