Remove Timex from ICal.Recurrence module#36
Merged
aseigo merged 3 commits intoApr 11, 2026
Conversation
Both functions return 1 (Monday) through 7 (Sunday) by default, making this a direct 1:1 replacement with no behavior change.
Remove Timex.AmbiguousDateTime handling since stdlib shift functions do not return ambiguous datetime structs. Pattern match on Date/DateTime to dispatch to the correct module. Update shift_opts to use singular unit names (day, month, year) as required by stdlib Duration, replacing Timex's plural convention (days, months, years).
matthewlehner
commented
Apr 11, 2026
aseigo
approved these changes
Apr 11, 2026
aseigo
left a comment
aseigo
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Tests pass, compiles clean, credo is happy ... 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks off a bunch of stuff in #32