Add CHANGELOG.md advice to upgrading skill#70
Conversation
|
oh i did have some work previously but didn't get a chance to evaluate my change. just share if there's something useful https://gist.github.com/Kudo/126e1d814bba6b8379b97a7db7ecdc44 |
Kudo
left a comment
Kudo
left a comment
There was a problem hiding this comment.
thanks for following up the idea!
|
@Kudo oooo I like yours! I can try to adapt it into this |
|
@Kudo I integrated your process into the doc. Let me know if this looks OK. |
|
looks good! just having an idea that we can move the steps to a dedicated reference file and link it from the skill |
| ## Step-by-Step Upgrade Process | ||
|
|
||
| 1. Upgrade Expo and dependencies | ||
| 1. Review breaking changes (see "Review CHANGELOG Breaking Changes" above) |
There was a problem hiding this comment.
there's the "## Breaking Changes Checklist" section below. maybe we can reuse it.
also, i think breaking changes migration should happen after npx expo install --fix
| - ./references/expo-av-to-video.md -- SDK +55: Migrate video playback from expo-av to expo-video | ||
| - ./references/react-navigation-to-expo-router.md -- SDK +56: Migrate `@react-navigation/*` imports to `expo-router` entry points (codemod + manual mapping) | ||
|
|
||
| ## Review CHANGELOG Breaking Changes |
There was a problem hiding this comment.
maybe it's worth to move it into a dedicated ./references/check-breaking-changes.md
| 4. Clear caches and reinstall | ||
|
|
||
| ```bash | ||
| npx expo export -p ios --clear |
There was a problem hiding this comment.
[Re: line +93]
- Check for removed APIs and breaking changes in release notes - `./references/check-breaking-changes.md`.
See this comment inline on Graphite.
Co-authored-by: Kudo Chien <kudo@expo.dev>
2 participants
This was just an idea for how we might guide the upgrading skill towards:
a) changelog breaking changes that are in CHANGELOG.md but not in the changelog blog at expo.dev/changelog, since that collection process is more rigorous and automated.
b) changelog breaking changes that could affect outside code interactions. This was inspired by a breaking change to notification behavior that would have required a change to the payload of the notification itself, so it's likely the upgrade skill would not be able to fix it on its own.