Skip to content

chore: update Expo upgrade workflow to continue to next on failure #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byCedric wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: update Expo upgrade workflow to continue to next on failure #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a2b7d
chore: update Expo upgrade workflow to continue to next on failure
byCedric May 23, 2026
1339f60
chore: manually exclude tvOS examples
byCedric May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/upgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ jobs:
pull-requests: write
steps:
- name: 🏗️ Setup repo
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: 🏗️ Setup Node
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: 20.x
node-version: 22.x

- name: 🏗️ Setup Bun
uses: oven-sh/setup-bun@v1
Expand Down
25 changes: 21 additions & 4 deletions upgrade-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ if [ "$1" == "--upgrade-expo" ]; then
DIRNAME=${d%/}
echo "Upgrading $DIRNAME..."

if [ "$DIRNAME" == "with-tv" ] || [ "$DIRNAME" == "with-router-tv" ]; then
echo "$DIRNAME requires manual attention"
continue
fi

if [ -z ${CI} ]; then
echo "• Run $manager install";
(cd $DIRNAME && $manager install --ignore-scripts &> ../.sdk-upgrade-logs/$DIRNAME-install.txt || echo "FAILURE")
Expand All @@ -34,7 +39,10 @@ if [ "$1" == "--upgrade-expo" ]; then
(cd $DIRNAME && $manager install --ignore-scripts)
exitCode=$?
echo "::endgroup::"
if [ $exitCode -ne 0 ]; then echo -e "\033[0;31mFAILURE\033[0m"; fi
if [ $exitCode -ne 0 ]; then
echo -e "\033[0;31mFAILURE\033[0m"
continue
fi
fi

if [ -z ${CI} ]; then
Expand All @@ -45,7 +53,10 @@ if [ "$1" == "--upgrade-expo" ]; then
(cd $DIRNAME && $manager add expo@$expoVersion && $manager expo install --fix)
exitCode=$?
echo "::endgroup::"
if [ $exitCode -ne 0 ]; then echo -e "\033[0;31mFAILURE\033[0m"; fi
if [ $exitCode -ne 0 ]; then
echo -e "\033[0;31mFAILURE\033[0m"
continue
fi
fi
done

Expand All @@ -61,7 +72,10 @@ if [ "$1" == "--upgrade-expo" ]; then
(cd $DIRNAME && yarn install)
exitCode=$?
echo "::endgroup::"
if [ $exitCode -ne 0 ]; then echo -e "\033[0;31mFAILURE\033[0m"; fi
if [ $exitCode -ne 0 ]; then
echo -e "\033[0;31mFAILURE\033[0m"
continue
fi
fi

if [ -z ${CI} ]; then
Expand All @@ -72,7 +86,10 @@ if [ "$1" == "--upgrade-expo" ]; then
(cd $DIRNAME && yarn add expo@$expoVersion && yarn expo install --fix)
exitCode=$?
echo "::endgroup::"
if [ $exitCode -ne 0 ]; then echo -e "\033[0;31mFAILURE\033[0m"; fi
if [ $exitCode -ne 0 ]; then
echo -e "\033[0;31mFAILURE\033[0m"
continue
fi
fi
done

Expand Down
Loading