-
Notifications
You must be signed in to change notification settings - Fork 0
Add IO position enrichment tool + backfill Eventide H90 (#212) #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4e40606
Add IO position enrichment tool + backfill Eventide H90 (#212)
jeffreylouden 3afa8ee
H90: model audio I/O level as software-switchable
jeffreylouden 2bf01d5
Address review: validate enrich-io slug, clarify rowPosition axis
jeffreylouden 5c7a479
H90: MIDI In/Out on the Left side, not the rear
jeffreylouden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| "catalog": minor | ||
| --- | ||
|
|
||
| Add IO port positioning (`columnPosition` / `rowPosition`) enrichment. | ||
|
|
||
| Starts issue #212: IO ports can now carry `columnPosition` (left-to-right) and | ||
| `rowPosition` (top-to-bottom) values describing their spatial arrangement on a | ||
| device edge, so the setup graph can render port layouts accurately. The schema | ||
| already accepted these fields; this adds the convention, tooling, and first data. | ||
|
|
||
| - New `pnpm enrich-io <slug>` interactive tool to assign column/row positions to a | ||
| hardware entry's IO ports, writing back to YAML while preserving formatting. | ||
| - Document the ordering convention in `schema/CONTEXT.md` (via the generator) and | ||
| `CLAUDE.md`. | ||
| - Fully correct and backfill the Eventide H90 Harmonizer as the validation case: | ||
| its IO now lists all 14 discrete rear-panel jacks (Inputs 1–4, Outputs 1–4, | ||
| Exp/Ctl 1–2, MIDI In, MIDI Out/Thru, USB-C, Power) with column/row positions, | ||
| replacing an incomplete 5-entry list that omitted the audio I/O and MIDI Out and | ||
| mis-positioned the jacks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.