Skip to content

Implement Poker Practice Exercise#1640

Open
thibault2705 wants to merge 10 commits into
exercism:mainfrom
thibault2705:poker
Open

Implement Poker Practice Exercise#1640
thibault2705 wants to merge 10 commits into
exercism:mainfrom
thibault2705:poker

Conversation

@thibault2705
Copy link
Copy Markdown

This PR implements the ticket New Exercise ✨: Poker #485.

@github-actions
Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions
Copy link
Copy Markdown
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@SleeplessByte SleeplessByte reopened this Apr 20, 2026
Comment thread exercises/practice/say/say.test.ts Outdated
@SleeplessByte
Copy link
Copy Markdown
Member

image

@thibault2705 there seem to be some issues.

  1. The title of two tests being the same (please check tests.toml)
  2. The type; adding a return type to the bestHands function may resolve it. It's okay to use the correct type -- there is no real surprise or learning goal for the return type.

@thibault2705
Copy link
Copy Markdown
Author

thibault2705 commented Apr 22, 2026

Hi @SleeplessByte, thanks for your review. I fixed the following points in my latest commit 8f4b306:

  1. According to tests.toml, I removed the unused test case in poker.test.ts
  2. Return type string[] added to the bestHands method.

@SleeplessByte
Copy link
Copy Markdown
Member

/format

@github-actions
Copy link
Copy Markdown
Contributor

The "Format code" action has started running.

@github-actions
Copy link
Copy Markdown
Contributor

The "Format code" action has finished running.

@github-actions
Copy link
Copy Markdown
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte
Copy link
Copy Markdown
Member

The typechecks are still failing. I'll try to find out why when i get a minute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants