[long-task] [long-task] [Phase 2] データフィールドカタログ用の語彙追加（dbp:DataFieldType / dbp:CompressionHint ほか） (#16) [ready for review] - #17
Merged
nagata-yoshiteru merged 3 commits intoJul 14, 2026
Conversation
…mpressionHint) Issue #16 (Phase 2): add vocabulary for the data field catalogue. - New class dbp:DataFieldType (rdfs:Class, subClassOf schema:Intangible): dataset-independent kind of a data field - New class dbp:CompressionHint: recommended compression settings per use case - New properties: dbp:fieldType (RealWorldDataStructureProperty -> DataFieldType), dbp:aliases, dbp:provenance, dbp:useCase, dbp:accuracyNote, dbp:compressionHints - Reused schema.org terms per the generator's existing convention: schema:status, schema:version, schema:dateModified, schema:supersededBy, schema:unitText, schema:unitCode - Reused existing dbp properties (itemType, variableScaleType, rangeMin/Max, decimalPlaces, isEnumValue, enumList, valueSamples, dbpaDatetimeFormat, dbpaTimestampUnitText, isMostly*/isOptional/isNullable, tags, compression-related recommendation values) - ProtoToJsonld.py: update rdfs:subClassOf when a forward-referenced class's message definition carries an explicit (subclass of: "...") marker (needed so DataFieldType gets schema:Intangible; no change to existing output) The JSON-LD files are regenerated from the protos with ProtoToJsonld.py. Diff verified purely additive: no existing definition removed or altered (existing nodes only gain schema:domainIncludes / schema:rangeIncludes entries), @context base URI unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
14 tasks
Reflect the DataFieldType / CompressionHint additions (commit 8af6ec8) into the checked-in generated code: - src/dbp_schema.rs: regenerated via cargo build (tonic-build 0.9.2 / prost-build 0.11.9, protoc 33.1). Purely additive (+119 lines); crate compiles. - dbp_schema.pb.go: regenerated with the exact pinned tool versions from the file header (protoc-gen-go v1.36.10, protoc v6.33.1 = protobuf release 33.1) via `protoc --go_out=. --go_opt=Mdbp_schema.proto=./ dbp_schema.proto`. Reproducibility verified before regenerating: with main's proto, both toolchains reproduce the checked-in outputs byte-identically, so the diffs contain only the vocabulary additions (plus protoc-gen-go's mechanical descriptor/type-index renumbering, 37 -> 39 messages). dbp_schema.sql / dbdiagram-oss_exported_data.json are hand-maintained dbdiagram artifacts (not proto-generated) and are left untouched; see the progress comment on issue #16. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reflect the new data field catalogue vocabulary into the manually maintained diagram sources, per issue author's request: - dbp_schema.sql (DBML): append DataFieldType / CompressionHint tables mirroring the proto fields (tags omitted, matching the existing convention of not materializing RealWorldDataTags in the diagram), with Refs for supersededBy and compressionHints - dbdiagram-oss_exported_data.json: append the same tables to the embedded DBML source (Text/CRLF style) and add chart layout entries (tables 27/28, refs 39/40); existing layout ids 1-26 / 1-38 unchanged Both DBML sources parse with @dbml/core and are byte-consistent modulo the established VARCHAR(256)->Text and LF->CRLF substitutions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
changed the title
Contributor
|
Claude finished @github-actions[bot]'s task —— View job PR レビュー: データフィールドカタログ語彙追加（dbp:DataFieldType / dbp:CompressionHint）
結論: ブロッキングな問題は見つかりませんでした。 6 種類の成果物（proto en/ja、JSON-LD en/ja、Go、Rust、SQL、dbdiagram）の間で語彙定義が一貫しており、マージ可能な品質と判断します。以下、確認内容と軽微な指摘です。 整合性チェック（機械検証済み）
軽微な指摘（任意対応）
未検証の項目
セキュリティ・パフォーマンス面の懸念はありません（スキーマ定義のみの変更）。 --- | Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #16 の長期タスク。進捗は Issue 内の bot コメントを参照してください。