Review Go and Rust code changes for naming consistency - #15
Draft
nagata-yoshiteru with Copilot wants to merge 1 commit into
Draft
Review Go and Rust code changes for naming consistency#15nagata-yoshiteru with Copilot wants to merge 1 commit into
nagata-yoshiteru with Copilot wants to merge 1 commit into
Conversation
Merged
Copilot
AI
changed the title
[WIP] Update capitalization in variable names
Review Go and Rust code changes for naming consistency
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the capitalization changes across proto, Go, and Rust files for consistency as requested.
Review Summary
All changes are consistent across the three codebases:
camelCasefield names (variableScaleType,stripTrailingZeros,useRunLength)PascalCaseexported fields (VariableScaleType,StripTrailingZeros,UseRunLength)snake_casefields (variable_scale_type,strip_trailing_zeros,use_run_length)Verified Fields
stripTrailingZerosStripTrailingZerosstrip_trailing_zerosuseRunLengthUseRunLengthuse_run_lengthuseFFTCompressionUseFFTCompressionuse_fft_compressionuseBaseIncrementUseBaseIncrementuse_base_incrementlossyCompressionRateLossyCompressionRatelossy_compression_ratedecimalPlacesDecimalPlacesdecimal_placesbaseIncrementBaseIncrementbase_incrementprecisionBytesPrecisionBytesprecision_bytesrangeMinRangeMinrange_minrangeMaxRangeMaxrange_maxvariableScaleTypeVariableScaleTypevariable_scale_typeEnum Types
Consistent across all files:
VariableScaleTypeEnumerationVariableCharacteristicEnumerationConversionCharacteristicEnumeration💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.