Skip to content

💄 app: misc fixes#1056

Open
dieguezguille wants to merge 2 commits into
mainfrom
fixes
Open

💄 app: misc fixes#1056
dieguezguille wants to merge 2 commits into
mainfrom
fixes

Conversation

@dieguezguille
Copy link
Copy Markdown
Member

@dieguezguille dieguezguille commented May 29, 2026

Summary by CodeRabbit

  • Style
    • Improved alignment of the back button in the activity details view.

Review Change Stack

@dieguezguille dieguezguille self-assigned this May 29, 2026
@dieguezguille dieguezguille added the bug Something isn't working label May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@dieguezguille, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 060ee2dd-9f1f-4bac-9845-2d3ed77dcc3a

📥 Commits

Reviewing files that changed from the base of the PR and between 252e68b and ecc36c0.

📒 Files selected for processing (2)
  • .changeset/calm-games-listen.md
  • src/components/home/Portfolio.tsx

Walkthrough

This PR removes the XStack layout wrapper around the back navigation button in the ActivityDetails component to align it properly. The import is removed and the IconButton is rendered directly while preserving the same navigation behavior. A changeset entry documents this patch-level fix.

Changes

Back button alignment in activity details

Layer / File(s) Summary
Back button alignment fix
src/components/activity/details/ActivityDetails.tsx, .changeset/tame-mirrors-brush.md
Remove XStack import and replace the IconButton nested inside XStack with a standalone IconButton. Navigation behavior is preserved: calls router.back() when available, otherwise replaces with /(main)/(home). Changeset documents the patch release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • cruzdanilo
  • franm91
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title '💄 app: misc fixes' is vague and does not reflect the specific change made. The actual change is about aligning the back button in activity details, but the title uses generic language ('misc fixes') that doesn't convey meaningful information about what was fixed. Consider revising the title to be more specific, such as '💄 app: align back button in activity details' to clearly describe the main change and make it easier for reviewers to understand the purpose of this pull request.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to align the back button in the activity details view by removing its wrapping XStack container and applying alignSelf="flex-start" directly to the IconButton. However, the reviewer points out that because the parent GradientScrollView uses stickyHeader, removing the full-width XStack wrapper can cause layout and rendering issues on some platforms. It is recommended to keep the XStack import and wrap the IconButton inside it to ensure consistent sticky header behavior.

Comment thread src/components/activity/details/ActivityDetails.tsx
Comment thread src/components/activity/details/ActivityDetails.tsx
@dieguezguille dieguezguille changed the title 💄 app: align back button in activity details 💄 app: misc fixes May 29, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 29, 2026

🦋 Changeset detected

Latest commit: ecc36c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant