Feat/session responses#277
Conversation
When an item is awarded, everyone's response to the session is now collected from the voting frame and stored on the history entry as `sessionResponses`. Only actual (numeric) responses are included - passes and status texts are skipped, and the winner only contributes ilvl and roll since the rest of their data is already on the entry. The Loot History gains a dice button on entries with session responses, opening a popup showing each candidate's response, note, ilvl, roll and votes, with the winner marked and sorted first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LibWindow calculates drag and save positions relative to the frame's parent, causing erratic snapping when parented to the (movable, scaled) history frame, and saved positions could resolve off-screen. The frame is also raised on show so it isn't stuck behind the history window, and gains a close button (escape works too). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Good job - looks fine. Speaking of comms, I'll need to do some extensive testing to see exactly what the impact is, not to mention how much storage this takes up and how it affects exports. I might just require this to be opt-in on the reciepient side (maybe you can add this?) to avoid overly large SV's for the average raider that doesn't care about this (bigger files = larger load times). |
Session responses can grow the loot history considerably over time, so collection is now gated behind a new 'Save Session Responses' toggle in the Loot History options, disabled by default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The Save Session Responses setting now also applies on the receiving end: session responses are stripped from incoming history entries unless the user has enabled it, so the ML controls collection while each user controls their own storage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Making the setting opt-out rather than opt-in - users concerned about storage can disable it in the Loot History options. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
@evil-morfar added setting now, defaulted it to on - change as you feel :) |
|
Byte size for a history comm after compression: |
|
I'm running out of ideas, but I managed to get a history comm down to just 1 extra message instead of the original 2. Best case specifics: |
2 participants
New version of evil-morfar/RCLootCouncil_Classic#65 into the core addon.
Ties data sync to ML award and simply expands history data with responses.
/rc history now looks like this, with a dice icon next to awards with saved responses
Click to reveal responses with notes etc:
