Skip to content

Add search box#179

Open
mtoebes wants to merge 4 commits into
evil-morfar:developfrom
mtoebes:master
Open

Add search box#179
mtoebes wants to merge 4 commits into
evil-morfar:developfrom
mtoebes:master

Conversation

@mtoebes

@mtoebes mtoebes commented Dec 26, 2019

Copy link
Copy Markdown

Problem: the history frame only allows you to search one player name at a time. In addition, that player name must be selected from a long scrollable list.

solution: add a search box.

Player names (excluding the realm name) can be added/removed by clicking on their name from the scrollable list or by typing it into the box. The logic uses string begins with to find matches. This also allows for multiple player exports.

Bonus: add an option to switch search to be by class or item name (not export enabled)

@evil-morfar

Copy link
Copy Markdown
Owner

Interesting. I'm currently on vacation so a full review will have to wait, but I imagine this could go into v2.17 I plan to release for patch 8.3.

@evil-morfar
evil-morfar changed the base branch from master to develop January 12, 2020 15:48
@evil-morfar

Copy link
Copy Markdown
Owner

@mtoebes Did you intend to finish this?

@mtoebes

mtoebes commented Mar 3, 2020

Copy link
Copy Markdown
Author

If you are interested in the idea, I'll resolve the conflicts. Else, I'll close the PR.

@evil-morfar

Copy link
Copy Markdown
Owner

I am interested

@mtoebes

mtoebes commented Apr 8, 2020

Copy link
Copy Markdown
Author

I merged in the lastest master. should to rdy for another looking at.

Unrelated. I think a guildie ran into some tiny bugs (that I have not seen for myself).

Can you check that time_remaning isn't meant to be time_remaining in ml_core (causing a arithmetic on nil value error at like 432).

Also, are the params going into self:ScheduleTimer("LootOpened", count / 10, autoloot, count) in Module::91 correct? I think the autoloot flag is being used for count in the method. This is causing an arithmetic error on local count (a boolean value) at line 87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants