Add pagination and session-SQL support from 0.0.10 build#33
Open
dnlw07 wants to merge 1 commit into
Open
Conversation
estimated row counts, connectionInitSql session support, one-row Statement/Result grids for no-result DML/DDL, and a stable resultId across pages (fixes a stuck-loading-spinner bug on page 2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bigquery-sqltools-0.0.10.vsixthat was never committed tosrc/SELECT/WITHqueries, with exact (COUNT(1)) or estimated row totals, cached per query runconnectionInitSqlconnection setting: runs once in a BigQuery session (createSession: true) right after connecting; the session is reused on subsequent queriespreviewLimit,disablePagination, anddisablePaginationCountconnection settings for controlling the new pagination behaviorINSERT/UPDATE/DELETE/MERGE/CREATE/DROP/ALTER/...) now show a one-rowStatement/Resultgrid instead of a blank "No rows returned" gridresultIdper page instead of keeping it stable across a query's pagesCHANGELOG.mdTest plan
npx tsc --noEmitpasses (aside from a pre-existing unrelatedgoogle-auth-librarytype error)yarn compile/tsupbuilds successfullySELECTquery (page forward/back, confirm no stuck spinner)connectionInitSqlsession setting connects and persists across queriesUPDATE/INSERTshows theStatement/Resultgrid