Skip to content

fix: make prop-derived chart values reactive (Area label position, Sparkline series type) #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajanpanth wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

fix: make prop-derived chart values reactive (Area label position, Sparkline series type) #3311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
779f78e
fix: make prop-derived chart values reactive to prop changes
rajanpanth Jul 24, 2026
1c09c69
fix: apply the same reactive derivation to Line's default label position
rajanpanth Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/reactive-prop-derivations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@evidence-dev/core-components': patch
---

Make prop-derived chart values reactive: Area's and Line's default label positions now follow `swapXY`, and Sparkline's series type follows `type`, instead of freezing at their mount-time values.
2 changes: 1 addition & 1 deletion packages/ui/core-components/src/lib/unsorted/viz/area/Area.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
middle: 'inside'
};

let defaultLabelPosition = swapXY ? 'right' : 'top';
$: defaultLabelPosition = swapXY ? 'right' : 'top';
$: labelPosition =
(swapXY ? swapXYLabelPositions[labelPosition] : labelPositions[labelPosition]) ??
defaultLabelPosition;
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/core-components/src/lib/unsorted/viz/core/_Sparkline.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
export let yScale = false; // scale the y axis to the data
$: yScale = yScale === 'true' || yScale === true;

let seriesType = type === 'area' ? 'line' : type;
$: seriesType = type === 'area' ? 'line' : type;

export let connectGroup = undefined; // connects to all other connected sparklines with the same group name (shared tooltip behaviour)

Expand Down
2 changes: 1 addition & 1 deletion packages/ui/core-components/src/lib/unsorted/viz/line/Line.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
middle: 'inside'
};

let defaultLabelPosition = swapXY ? 'right' : 'top';
$: defaultLabelPosition = swapXY ? 'right' : 'top';
$: labelPosition =
(swapXY ? swapXYLabelPositions[labelPosition] : labelPositions[labelPosition]) ??
defaultLabelPosition;
Expand Down