fix(auth): use-after-free bug when trying to find gsheet secret#105
Merged
mharrisb1 merged 2 commits intoFeb 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a use-after-free bug in
GetGSheetSecretthat causedread_gsheetandCOPY TOto fail on macOS with'token' not found in gsheet secret.GetGSheetSecretreturned a rawKeyValueSecret *pointing into aSecretMatchthat was destroyed when the function returned. The caller then read from freed memory. On Linux the allocator happened to leave the memory intact, masking the bug. On macOS the allocator reclaims the memory sooner, causingsecret_mapto appear empty.The fix inlines the secret access into
CreateAuthFromSecretso theSecretMatchstays alive on the stack for the duration of use.GetGSheetSecretis removed.